The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders #535

onedr0p · 2016-09-13T22:30:57Z

Here's a brief rundown of what I did and what is left to do.

In the Admin Setting for Sonarr:

Removed Folder Path textbox
Added button to grab root folders
Added drop down with Root folders
The code will send an API request to Sonarr and grab the folders when you hit the 'Get Root Folders' button https://github.com/Sonarr/Sonarr/wiki/Rootfolder
Updated some logic thru-out the program to accept a rootFolderId (like how you handled qualityId)

What's left to do:

Figure out why when you save it won't update the cache with the root folders grabbed.
It won't populate the root folders from cache when you save and reload the Admin Settings > Sonarr
Implement Approving requests with selecting a root folder.

…ith sepecific root folders

tidusjar · 2016-09-14T13:16:21Z

PlexRequests.UI/Modules/RequestsBetaModule.cs

@@ -186,6 +186,37 @@ private Negotiator LoadRequests()

            }

+            IEnumerable<RootFolderModel> rootFolders = new List<RootFolderModel>();


This module is not being used yet just a FYI, there is no code being used in this class

I figured as much, I just copied what I wrote in the RequestModule.cs :)

@onedr0p Ok that's fine :)

tidusjar · 2016-09-14T13:21:49Z

Looks good so far!

So the caching is not working for you?

onedr0p · 2016-09-14T13:26:09Z

Nope, I hit the button to grab the root folders, click save and reload the page and they are wiped out. I am clueless as to why :/

Also after I added the validation stuff in SonarrSettingsValidator it won't accept you even hitting Save. Sorry my C# is very bad lol

tidusjar · 2016-09-14T13:27:52Z

Hey that's fine. I can take a look tonight to see if I can find out what is going wrong.

Also after I added the validation stuff in SonarrSettingsValidator it won't accept you even hitting Save
What wouldn't accept? Not sure I understand.

Your C# is not bad! You've been able to read and understand what is going on and there is some confusing areas so that's execllent!

onedr0p · 2016-09-14T13:38:41Z

I have a strong Linux background, and I recently started a position as a VB.net web developer and I slowly getting up to par with the Microsoft environment. Thanks for taking a look!

tidusjar · 2016-09-14T20:10:14Z

OK, so just looked at your code, you are storing the root folders into the cache (Default cache expiry is 20 minutes). When we save the sonarr settings Here we are binding the results from the <form> being submitted and binding it to the model, in this case SonarrSettings.

Now SonarrSettings does not contain a definition for the root folders, so they are not being saved into the database.
So when reloading the page, we query the database for the SonarrSettings and the root folders do not exist.

So what we need to do is add a new property onto the SonarrSettings something like a string[] to store those root folders (You already have it in the cache, so just get it from the cache and assign it to the new string[] property 👍 ).

If you need any help please ask 😄

tidusjar · 2016-09-14T20:12:28Z

PlexRequests.UI/Views/Admin/Sonarr.cshtml

+                data: $form.serialize(),
+                url: "sonarrrootfolders",
+                dataType: "json",
+                success: function(response) {


There is a bug here where if we keep pressing the Get RootFolders it will keep appending to the list :)

I noticed that lol, it's not an important fix for right now thou

tidusjar · 2016-09-14T20:13:08Z

PlexRequests.UI/Views/Admin/Sonarr.cshtml

@@ -80,12 +80,24 @@
            </div>

            <div class="form-group">
+                <div>
+                    <button type="submit" id="getRootFolders" class="btn btn-primary-outline">Get RootFolders <div id="getRootFolderSpinner" /></button>


Can we include a space in RootFolders so it's Root Folders ?

Yeah that makes sense :)

tidusjar

See comments

onedr0p · 2016-09-14T21:31:14Z

Now SonarrSettings does not contain a definition for the root folders, so they are not being saved into the database.

In teh SonarrSettings class I have

        public bool Enabled { get; set; }
        public string ApiKey { get; set; }
        public string QualityProfile { get; set; }
        public string RootFolder { get; set; }
        public string RootPath { get; set; }
        public bool SeasonFolders { get; set; }

The array of paths will also be stored here with the one the user selected? Or should I change it to:

        public bool Enabled { get; set; }
        public string ApiKey { get; set; }
        public string QualityProfile { get; set; }
        public string[] RootFolder { get; set; }
        // public string RootPath { get; set; }
        public bool SeasonFolders { get; set; }

onedr0p · 2016-09-14T21:31:40Z

Using those new github features I see :P

tidusjar · 2016-09-15T06:58:16Z

Well you need to know the one the user selected right?

Ignore my other comment, when saving we need to get it out of the cache and set the one the user picked into the RootFolders property.

On the approve page we can just request the root folder from Sonarr again.

Magikarplvl4 · 2016-10-27T20:58:06Z

@onedr0p is the pull ready for merge?

tidusjar · 2016-10-27T22:03:19Z

It's not finished yet. I think I'll merge it in and then finish it off :)

onedr0p · 2017-01-12T05:49:49Z

Sorry for the late response, please continue where I left off.

onedr0p added 2 commits September 13, 2016 15:22

The begining of grabbing sonarr root folders and approving requests w…

05ded0d

…ith sepecific root folders

Forgot the Models

f8b4f40

tidusjar reviewed Sep 14, 2016
View reviewed changes

tidusjar reviewed Sep 14, 2016

View reviewed changes

tidusjar requested changes Sep 14, 2016

View reviewed changes

tidusjar approved these changes Sep 14, 2016

View reviewed changes

tidusjar mentioned this pull request Oct 17, 2016

[FR] Sonarr - Multiple Root save directories for TV shows #445

Closed

Magikarplvl4 mentioned this pull request Oct 27, 2016

Specify a Sonarr file path on approval #170

Closed

Magikarplvl4 added the in progress label Nov 3, 2016

Magikarplvl4 added this to the Release v2.0 milestone Nov 3, 2016

Magikarplvl4 added next to work on planned and removed planned next to work on labels Nov 3, 2016

tidusjar changed the title ~~The beggining of grabbing Sonarr root folders and approving requests with sepecific root folders~~ The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders Nov 16, 2016

Magikarplvl4 mentioned this pull request Dec 21, 2016

Version 2.X Release #828

Closed

Magikarplvl4 added the V2.0 label Dec 21, 2016

Magikarplvl4 modified the milestones: Release v2.0, V2.1 release Jan 4, 2017

Magikarplvl4 modified the milestones: 2.2, V2.X release pool Jan 12, 2017

tidusjar closed this Jan 23, 2017

tidusjar removed in progress planned labels Jan 23, 2017

tidusjar pushed a commit that referenced this pull request Jan 23, 2017

Finished #535 #445 #170

7fc26df

Magikarplvl4 modified the milestones: Release v2.1, Release v2.2 Jan 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders #535

The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders #535

onedr0p commented Sep 13, 2016 •

edited

Loading

tidusjar Sep 14, 2016

onedr0p Sep 14, 2016

tidusjar Sep 14, 2016

tidusjar commented Sep 14, 2016

onedr0p commented Sep 14, 2016

tidusjar commented Sep 14, 2016

onedr0p commented Sep 14, 2016 •

edited

Loading

tidusjar commented Sep 14, 2016

tidusjar Sep 14, 2016

onedr0p Sep 14, 2016

tidusjar Sep 14, 2016

onedr0p Sep 14, 2016

tidusjar left a comment

onedr0p commented Sep 14, 2016

onedr0p commented Sep 14, 2016

tidusjar commented Sep 15, 2016

Magikarplvl4 commented Oct 27, 2016

tidusjar commented Oct 27, 2016

onedr0p commented Jan 12, 2017

		@@ -186,6 +186,37 @@ private Negotiator LoadRequests()

		}

		IEnumerable<RootFolderModel> rootFolders = new List<RootFolderModel>();

The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders #535

The beginning of grabbing Sonarr root folders and approving requests with sepecific root folders #535

Conversation

onedr0p commented Sep 13, 2016 • edited Loading

tidusjar Sep 14, 2016

Choose a reason for hiding this comment

onedr0p Sep 14, 2016

Choose a reason for hiding this comment

tidusjar Sep 14, 2016

Choose a reason for hiding this comment

tidusjar commented Sep 14, 2016

onedr0p commented Sep 14, 2016

tidusjar commented Sep 14, 2016

onedr0p commented Sep 14, 2016 • edited Loading

tidusjar commented Sep 14, 2016

tidusjar Sep 14, 2016

Choose a reason for hiding this comment

onedr0p Sep 14, 2016

Choose a reason for hiding this comment

tidusjar Sep 14, 2016

Choose a reason for hiding this comment

onedr0p Sep 14, 2016

Choose a reason for hiding this comment

tidusjar left a comment

Choose a reason for hiding this comment

onedr0p commented Sep 14, 2016

onedr0p commented Sep 14, 2016

tidusjar commented Sep 15, 2016

Magikarplvl4 commented Oct 27, 2016

tidusjar commented Oct 27, 2016

onedr0p commented Jan 12, 2017

onedr0p commented Sep 13, 2016 •

edited

Loading

onedr0p commented Sep 14, 2016 •

edited

Loading